maciejpi/nordabiz
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(messages): root cause of double messages — polling re-adds sent message
Some checks are pending
NordaBiz Tests / Unit & Integration Tests (push) Waiting to run
Details
NordaBiz Tests / E2E Tests (Playwright) (push) Blocked by required conditions
Details
NordaBiz Tests / Smoke Tests (Production) (push) Blocked by required conditions
Details
NordaBiz Tests / Send Failure Notification (push) Blocked by required conditions
Details

Browse Source 
The actual bug: Composer.send() appends message to DOM via appendMessage(),
then 1-5s later the polling loop fetches the same message from API and
appends it again. Fix: track sent messages in state.messages[convId] so
the polling dedup check (msg.id > newestId) filters them out.

Also removed debug logging.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Maciej Pienczyn 2026-03-28 16:35:19 +01:00
parent 9151e4efa0
commit 720d7a2d7d
2 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
blueprints/messages/message_routes.py
View File

@ -183,8 +183,6 @@ def get_messages(conv_id):
@member_required @member_required
def send_message(conv_id): def send_message(conv_id):
"""Send a message to a conversation.""" """Send a message to a conversation."""
import logging
logging.getLogger(__name__).info(f"[MSG-DEBUG] send_message called: conv={conv_id}, user={current_user.id}, method={request.method}")
db = SessionLocal() db = SessionLocal()
try: try:
# Verify membership # Verify membership

8
static/js/conversations.js
View File

@ -1211,7 +1211,6 @@
if (e.key === 'Enter' && !e.shiftKey) { if (e.key === 'Enter' && !e.shiftKey) {
e.preventDefault(); e.preventDefault();
e.stopImmediatePropagation(); e.stopImmediatePropagation();
console.log('[MSG-DEBUG] Enter keydown captured, _isSending=' + state._isSending + ', _lastSendTime=' + state._lastSendTime);
Composer.send(); Composer.send();
} }
}, true); }, true);
@ -1225,7 +1224,6 @@
var sendBtn = document.getElementById('sendBtn'); var sendBtn = document.getElementById('sendBtn');
if (sendBtn) { if (sendBtn) {
sendBtn.addEventListener('click', function () { sendBtn.addEventListener('click', function () {
console.log('[MSG-DEBUG] Send BUTTON clicked');
Composer.send(); Composer.send();
}); });
} }
@ -1259,12 +1257,10 @@
// Double-send guard: flag + timestamp debounce (500ms) // Double-send guard: flag + timestamp debounce (500ms)
var now = Date.now(); var now = Date.now();
if (state._isSending || (state._lastSendTime && now - state._lastSendTime < 500)) { if (state._isSending || (state._lastSendTime && now - state._lastSendTime < 500)) {
console.log('[MSG-DEBUG] send() BLOCKED: _isSending=' + state._isSending + ', timeSinceLast=' + (now - (state._lastSendTime || 0)) + 'ms');
return; return;
} }
state._isSending = true; state._isSending = true;
state._lastSendTime = now; state._lastSendTime = now;
console.log('[MSG-DEBUG] send() EXECUTING at ' + now);
var html = state.quill.root.innerHTML; var html = state.quill.root.innerHTML;
var text = state.quill.getText().trim(); var text = state.quill.getText().trim();
@ -1294,8 +1290,10 @@
if (replyPreview) replyPreview.style.display = 'none'; if (replyPreview) replyPreview.style.display = 'none';
Composer.renderAttachments(); Composer.renderAttachments();
// Append the sent message // Append the sent message and track it so polling doesn't duplicate
ChatView.appendMessage(result); ChatView.appendMessage(result);
if (!state.messages[convId]) state.messages[convId] = [];
state.messages[convId].push(result);
// Update conversation in list // Update conversation in list
ConversationList.updateConversation(convId, { ConversationList.updateConversation(convId, {